.github/workflows/raise-pr-for-constants.yml (2)

34-45: Enhance error handling and file validation

The script should validate file existence and handle potential errors more robustly.

Consider adding:

 run: |
+          if [ ! -f "$SRC_FILE" ]; then
+            echo "Error: Source file $SRC_FILE not found"
+            exit 1
+          fi
+
+          if [ ! -f "dest-repo/$DEST_PATH" ]; then
+            echo "Error: Destination file not found"
+            exit 1
+          fi
+
           if cmp -s "$SRC_FILE" "dest-repo/$DEST_PATH"; then

🧰 Tools

🪛 actionlint (1.7.4)

34-34: shellcheck reported issue in this script: SC2034:warning:2:1: DEST_REPO appears unused. Verify use (or export if used externally)

(shellcheck)

---

34-34: workflow command "set-output" was deprecated. use echo "{name}={value}" >> $GITHUB_OUTPUT instead: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions

(deprecated-commands)

---

34-34: workflow command "set-output" was deprecated. use echo "{name}={value}" >> $GITHUB_OUTPUT instead: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions

(deprecated-commands)

---

62-67: Add PR title and body for better context

The current PR creation lacks descriptive information.

Consider enhancing the PR creation:

           if [ -z "$EXISTING_PR" ]; then
-            gh pr create -f
+            gh pr create \
+              --title "chore: update destination constants" \
+              --body "This PR updates the destination constants file.
+
+              - Auto-generated by GitHub Actions
+              - Source: rudderlabs/rudder-integrations-config
+              " \
+              --label "automated,constants"
           else
             echo "PR already exists: $EXISTING_PR"
           fi

Configuration used: CodeRabbit UI
Review profile: CHILL

#!/bin/bash
# Check if the destination repository exists and is accessible
gh repo view rudderlabs/rudder-sdk-js --json name,visibility,isArchived

# Check if there are any existing PRs from this workflow
gh pr list -R rudderlabs/rudder-sdk-js \
  --search "author:app/github-actions in:title update destination constants" \
  --json number,title,state

#!/bin/bash
# Check the workflow configuration for permissions and token usage
cat .github/workflows/raise-pr-for-constants.yml

# Check if there are any other workflows that interact with the same repository
rg -l "rudderlabs/rudder-sdk-js" .github/workflows/

.github/workflows/raise-pr-for-constants.yml (1)

12-14: Consider using a dynamic branch name.

The hardcoded branch name could cause conflicts if multiple PRs need to be created simultaneously. Consider including a timestamp or unique identifier.

 env:
-  BRANCH_NAME: chore/gh-update-destinations-ts
+  BRANCH_NAME: chore/gh-update-destinations-ts-${{ github.run_id }}

Configuration used: CodeRabbit UI
Review profile: CHILL

.github/workflows/raise-pr-for-constants.yml (1)

56-61: Enhance commit operation with better error handling and message.

The commit operation needs better error handling and a more descriptive commit message.

 cd dest-repo
-cp "../generated/Destinations.ts" "packages/analytics-js-common/src/constants/integrations/Destinations.ts"
+cp "../${{ env.SRC_FILE }}" "${{ env.DEST_PATH }}" || {
+  echo "Error: Failed to copy file"
+  exit 1
+}
 git add packages/analytics-js-common/src/constants/integrations/Destinations.ts
-git commit -m "chore: update destinations.ts"
+git commit -m "chore: update destination constants
+
+Update Destinations.ts with latest constants from source repository"
 git push origin ${{ env.BRANCH_NAME }}

Configuration used: CodeRabbit UI
Review profile: CHILL

-gh pr create -f
+gh pr create \
+  --title "chore: update destination constants [automated]" \
+  --body "## Description
+
+This PR updates the destination constants file with the latest changes.
+
+## Changes
+- Updated \`Destinations.ts\` with latest constants from source repository
+
+This PR was automatically generated by GitHub Actions." \
+  --label "automated"

-git clone https://github.com/${DEST_REPO}.git dest-repo || exit 1
+uses: actions/checkout@v4
+with:
+  repository: ${DEST_REPO}
+  path: dest-repo
+  token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/raise-pr-for-constants.yml (2)

56-61: Improve file operations and commit message

Consider these improvements:

1. Use environment variables consistently
2. Add more descriptive commit message

-cp "../generated/Destinations.ts" "packages/analytics-js-common/src/constants/integrations/Destinations.ts"
-git add packages/analytics-js-common/src/constants/integrations/Destinations.ts
-git commit -m "chore: update destinations.ts"
+cp "../${SRC_FILE}" "${DEST_PATH}"
+git add "${DEST_PATH}"
+git commit -m "chore: update destination constants [automated]
+
+This commit updates the destination constants file with the latest changes from the source repository."

---

70-78: Enhance PR creation with better metadata

Consider these improvements:

1. Remove trailing spaces
2. Add more context to PR description
3. Add additional useful labels

 gh pr create \
   --title "chore: update destination constants" \
   --body "This PR updates the destination constants file.

   **Changes:**
   - Updated \`Destinations.ts\` with latest constants
-              
+
   This PR was automatically generated by GitHub Actions." \
-  --label "automated,dependencies"
+  --label "automated,dependencies,no-changelog-needed" \
+  --assignee "@me"

🧰 Tools

🪛 yamllint (1.35.1)

[error] 76-76: trailing spaces

(trailing-spaces)

Configuration used: CodeRabbit UI
Review profile: CHILL

-git clone https://github.com/${DEST_REPO}.git dest-repo || exit 1
+git clone https://github.com/${DEST_REPO}.git dest-repo
+cd dest-repo
+git config --global url."https://${{ secrets.GITHUB_TOKEN }}@github.com/".insteadOf "https://github.com/"

-if cmp -s "${{ env.SRC_FILE }}" "dest-repo/${{ env.DEST_PATH }}"; then
+if cmp -s "${SRC_FILE}" "dest-repo/${DEST_PATH}"; then
   echo "No changes detected." > "result.txt"
   echo "pr_required=false" >> $GITHUB_OUTPUT
 else
   echo "Changes detected." > "result.txt"
   echo "pr_required=true" >> $GITHUB_OUTPUT
 fi

.github/workflows/raise-pr-for-constants.yml (2)

69-77: Enhance PR creation with better metadata and error handling

The PR creation needs improvements:

1. More descriptive title and body
2. Better error handling for file operations
3. More specific labels

-            gh pr create \
-              --title "fix: update destination constants" \
-              --body "This PR updates the destination constants file.
-
-              **Changes:**
-              - Updated \`Destinations.ts\` with latest constants
-              
-              This PR was automatically generated by GitHub Actions." \
-              --label "automated,dependencies"
+            {
+              echo "Changes in destination constants:"
+              diff -u "dest-repo/${{ env.DEST_PATH }}" "${{ env.SRC_FILE }}" || true
+            } > pr_diff.txt
+            
+            gh pr create \
+              --title "fix: update destination constants [$(date +%Y-%m-%d)]" \
+              --body "This PR updates the destination constants with the latest changes.
+
+              **Changes:**
+              - Updated \`Destinations.ts\` with latest constants from \`develop\` branch
+              
+              <details>
+              <summary>Detailed Changes</summary>
+              
+              \`\`\`diff
+              $(cat pr_diff.txt)
+              \`\`\`
+              </details>
+              
+              This PR was automatically generated by GitHub Actions.
+              
+              Related to: #${GITHUB_EVENT_NUMBER:-N/A}" \
+              --label "automated,dependencies,constants-update"

🧰 Tools

🪛 yamllint (1.35.1)

[error] 75-75: trailing spaces

(trailing-spaces)

---

75-75: Remove trailing whitespace

There is trailing whitespace on this line that should be removed.

-              
+

🧰 Tools

🪛 yamllint (1.35.1)

[error] 75-75: trailing spaces

(trailing-spaces)

Configuration used: CodeRabbit UI
Review profile: CHILL

-          git clone https://github.com/${DEST_REPO}.git dest-repo || exit 1
-          cd dest-repo
-          git config --global user.name "GitHub Actions"
-          git config --global user.email "[email protected]"
-          git config --global url."https://${{ secrets.GITHUB_TOKEN }}@github.com/".insteadOf "https://github.com/"
+          git config --global user.name "GitHub Actions"
+          git config --global user.email "[email protected]"
+          git clone https://github.com/${DEST_REPO}.git dest-repo || {
+            echo "Failed to clone repository"
+            exit 1
+          }
+          cd dest-repo || exit 1
+          git remote set-url origin "https://${{ secrets.GITHUB_TOKEN }}@github.com/${DEST_REPO}.git"